-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actionsでのビルドのupload/download回数を少なくしてビルド時間を短くする #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
準備できたのでdraft明けました。(なかなか大変でした・・・。) |
y-chan
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!特に問題ないと思います!
一点だけ気になった点があったのでコメントを残しました...!
レビューありがとうございます!! |
This was referenced Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決です。upl;oad/downloadを1回減らして15分ほど時間を短縮します。
関連 Issue
close #641
その他
ついでの変更点がいくつかあります。
softprops/action-gh-release@v1
からncipollo/release-action@v1
に変更リリースはこちら
このリリースと差分を比較すればOKなはず
差分比較用のコマンド
比較結果
(ディレクトリ構成が異なる場合などは「片方にしか無いもの」が現れるはず)