Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.ymlでGNU版のsedとsplitをenvに入れて明示的に実行 #702

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jun 19, 2023

内容

で出ていたエラーの解決です。

以前にmac環境でbsdではなくgnuのsedなどを使えるようにしたとき、actionsなどが利用するchmodなども置き換わってしまってエラーが発生するようになっていました。
グローバルなPATHを変えるのではなく、envに使用するコマンドを書き込むことで切り替えられるようにしました。

関連 Issue

close #698

スクリーンショット・動画など

その他

お試しビルドworkflowはこちらです
https://github.com/Hiroshiba/voicevox_engine/actions/runs/5316242261/jobs/9625551799

@Hiroshiba Hiroshiba requested a review from a team as a code owner June 19, 2023 21:29
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team June 19, 2023 21:29
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 2 1 coverage-50%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 3 1 coverage-67%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 14 coverage-52%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 152 9 coverage-94%
voicevox_engine/mora_list.py 5 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 3 1 coverage-67%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 159 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 9 2 coverage-78%
voicevox_engine/utility/mutex_utility.py 11 1 coverage-91%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 1415 284 coverage-80%

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba
Copy link
Member Author

レビューありがとうございます! たぶん問題ないのでマージします!

@Hiroshiba Hiroshiba merged commit 07aab5e into VOICEVOX:master Jun 20, 2023
@Hiroshiba Hiroshiba deleted the sedとsplitをenvに入れて明示的に実行 branch June 20, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Runner Image macos-11 20230612.1 (macOS 11.7.7)でバイナリビルドに失敗する
2 participants