Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

書き込み系のAPIを一括で無効化する引数・環境変数を追加 #895

Merged
merged 7 commits into from
Dec 26, 2023

Conversation

Hiroshiba
Copy link
Member

内容

こちらの課題を解決します。

プリセット・辞書・設定・音声ライブラリの変更を無効化できます。

関連 Issue

close #571

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner December 17, 2023 20:58
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team December 17, 2023 20:58
@Hiroshiba
Copy link
Member Author

@aoirint さんもレビューいただけると心強いです!!

Comment on lines -1307 to +1351
parser.add_argument(
"--use_gpu", action="store_true", help="指定するとGPUを使って音声合成するようになります。"
)
parser.add_argument("--use_gpu", action="store_true", help="GPUを使って音声合成するようになります。")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついでに実行実引数の説明をリファクタリングしました。
指定するとを省いています。(指定しない引数はないので)

Copy link

github-actions bot commented Dec 17, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 499 336 coverage-33%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/core_adapter.py 50 18 coverage-64%
voicevox_engine/core_wrapper.py 222 157 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 31 13 coverage-58%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 32 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 93 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 18 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 5 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 25 1 coverage-96%
voicevox_engine/tts_pipeline/kana_converter.py 86 1 coverage-99%
voicevox_engine/tts_pipeline/make_tts_engines.py 63 31 coverage-51%
voicevox_engine/tts_pipeline/mora_list.py 4 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 125 5 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 175 7 coverage-96%
voicevox_engine/tts_pipeline/tts_engine_base.py 20 3 coverage-85%
voicevox_engine/user_dict.py 144 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2246 740 coverage-67%

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
Dependsを使って簡単に挿入できるのいいですね....!

@Hiroshiba Hiroshiba merged commit dcac97d into VOICEVOX:master Dec 26, 2023
3 checks passed
@Hiroshiba Hiroshiba deleted the API無効化引数 branch December 26, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants