Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on auto translation #10

Closed
Lyaaaaaaaaaaaaaaa opened this issue Mar 9, 2022 · 8 comments
Closed

Error on auto translation #10

Lyaaaaaaaaaaaaaaa opened this issue Mar 9, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@Lyaaaaaaaaaaaaaaa
Copy link

Lyaaaaaaaaaaaaaaa commented Mar 9, 2022

Describe the bug:
When I start the automatic translation it hangs on after ~15-20%. And if I close Godot and re-opens it, I can see 15-20% has been translated.
I'm using Godot 3.4.3 on Linux.

Logs:
There is an infinity of these lines.

 core/io/http_client.cpp:326 - Condition "resolving == IP::RESOLVER_INVALID_ID" is true. Returned: ERR_BUG
 core/bind/core_bind.cpp:3216 - Error parsing JSON at line 0: 
 res://addons/localization_editor/scenes/auto_translate/google/LocalizationAutoTranslateGoogle.gd:91 - Invalid get index '0' (on base: 'Nil').
@VP-GAMES VP-GAMES added the bug Something isn't working label Mar 11, 2022
@VP-GAMES
Copy link
Owner

Hi, thx for bugreport, please give me more information. It looks like godot can't parse json comming from google translator. Can you give me your text / string that your send to translate.

@Lyaaaaaaaaaaaaaaa
Copy link
Author

Hi, I made a small project to demonstrate the error. I tried to translate the localizations.csv file from english to spanish and it stopped at 18%.
I hope this helps :).
auto_translation_demo.zip

@VP-GAMES
Copy link
Owner

VP-GAMES commented Mar 18, 2022

Hi, it's a bug in godot look here: godotengine/godot#25052
But i can try to implement workaround, to send request after request, not many requests at the same time.

@Lyaaaaaaaaaaaaaaa
Copy link
Author

Hi, I didn't know that. At least the bug is now identified.

@VP-GAMES
Copy link
Owner

In this moment, i implement a workaround

VP-GAMES added a commit that referenced this issue Mar 18, 2022
@VP-GAMES
Copy link
Owner

Here is my workaround: bc4754c
Please try it and give me feedback to close this issue.

@Lyaaaaaaaaaaaaaaa
Copy link
Author

It works very well. Though, if you add a new key and try to translate again, it will hang at 18% and won't translate the empty keys.
I also noticed there is problems saving the .CSV if you have " or , in the strings (Maybe you want me to open another issue for this one).

@VP-GAMES
Copy link
Owner

Open new issue, and please explain the issue

VP-GAMES added a commit to VP-GAMES/Godot4LocalizationEditor that referenced this issue Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants