Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenRouteService (ORS) as backend #203

Closed
sfendrich opened this issue Jan 21, 2019 · 7 comments
Closed

Add OpenRouteService (ORS) as backend #203

sfendrich opened this issue Jan 21, 2019 · 7 comments

Comments

@sfendrich
Copy link
Contributor

Add support for ORS as a backend for matrix and route computations.

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 21, 2019

Related to the discussion in #192.

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 21, 2019

@sfendrich thanks for the PR! I'll see if I can manage to setup an ORS server locally to test this out.

@sfendrich
Copy link
Contributor Author

If you have any problems with the ORS setup, don't hesitate to ask me for help.

@jcoupey jcoupey added this to the v1.4.0 milestone Jan 22, 2019
@jcoupey
Copy link
Collaborator

jcoupey commented Jan 22, 2019

@sfendrich thanks, I fiddled a bit with errors with the maven build but managed to get things going using docker.

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 22, 2019

I tested the branch locally and everything works fine. I just have a couple comments/questions in the PR review.

I was wondering how ORS deals with absent values in the matrix, but it turns out the existing null-handling code works out of the box (handy for example for points outside the dataset). I also checked plotting solutions through the frontend and everything is fine with the encoded geometry.

@sfendrich could you also mention the support for ORS as a routing engine in CHANGELOG.md?

@sfendrich
Copy link
Contributor Author

ORS also returns null if no route can be found.

I'll update the changelog as requested.

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 23, 2019

I just merged #204 so this is currently available in master and will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants