Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valhalla as routing provider #306

Closed
nilsnolde opened this issue Feb 26, 2020 · 1 comment · Fixed by #461
Closed

Add Valhalla as routing provider #306

nilsnolde opened this issue Feb 26, 2020 · 1 comment · Fixed by #461

Comments

@nilsnolde
Copy link
Contributor

I think Valhalla, despite its relatively poor performance compared to ORS/OSRM, would be a nice addition to Vroom's routing providers. It's really unique in terms of run-time weights & costs, no other router can match that, except for BRouter. Anyways, with Mapbox ending OSRM support in a few weeks time and fully concentrating on Valhalla, it might also be a step towards future.

Of course it's possible to add Valhalla already via custom matrices.

Actually I think I'd like to tackle this myself, if no one else jumps for it in the next weeks. Recently started some C++ dev and this seems rather easy.

@jcoupey
Copy link
Collaborator

jcoupey commented Mar 2, 2020

Adding support for another open-source routing engine can only make the project useful for more people so I'd be more than happy if you could contribute a wrapper for Valhalla.

Of course the impact on solving times would be significant as they would probably be mostly dominated by matrix computing times. But this is basically the same choice people are facing when picking a routing engine depending on what they want to use it for.

Technically, you can rely on how it's been done already by @sfendrich for the Openrouteservice wrapper, see #203 and #204. Happy to help if you have any question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants