Adapt URI to ORS production settings without default /ors base path #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoupey
reviewed
Nov 14, 2023
BREAKING-CHANGE: this removes the hardcoded `ors/v2/`
which now needs to be provided either in the cli using the `-a` flag
(e.g.`-a <profile>:<host>/ors/v2`)
or with `vroom-express` or `vroom-docker` in the `config.yml`
e.g.
```
routingServers:
ors:
driving-car:
host: "0.0.0.0/ors/v2"
port: 8082
```
Co-authored-by: Amandus Butzer <amandus.butzer@heigit.org>
TheGreatRefrigerator
force-pushed
the
ors-production
branch
from
92efa3d
to
e425c6a
Compare
|
@jcoupey i've tagged it as breaking now, if you disagree i will adjust and just provide the examples and link to vroom-express |
nilsnolde
reviewed
Nov 14, 2023
TheGreatRefrigerator
force-pushed
the
ors-production
branch
from
e425c6a
to
3913451
Compare
TheGreatRefrigerator
added a commit
to GIScience/vroom-express
that referenced
this pull request
Nov 15, 2023
BREAKING-CHANGE: this adjusts to the removal of the hard-coded ors base path in vroom see VROOM-Project/vroom#1037
jcoupey
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1036
Tasks
CHANGELOG.md(remove if irrelevant)