Code

Refactor cost wrapper#829

Code

Merged

jcoupey merged 37 commits intomasterVROOM-Project/vroom:masterfrom refactor/cost-wrapperVROOM-Project/vroom:refactor/cost-wrapperCopy head branch name to clipboardNov 23, 2022

+700-461

Commits

Commits on Nov 17, 2022

• Define a global DURATION_FACTOR value.

  jcoupey

  committed
  dc2cd42

  Copy full SHA for dc2cd42

• Use integers for set_costs_factor.

  jcoupey

  committed
  6c78e34

  Copy full SHA for 6c78e34

• Get rid of division in CostWrapper::duration/cost.

  jcoupey

  committed
  6ff89ab

  Copy full SHA for 6ff89ab

• Scale internal times for TimeWindow objects.

  jcoupey

  committed
  9580cf3

  Copy full SHA for 9580cf3

• Scale internal times for Break objects.

  jcoupey

  committed
  bd60ab0

  Copy full SHA for bd60ab0

• Scale internal times for Vehicle and VehicleStep objects.

  jcoupey

  committed
  31cc818

  Copy full SHA for 31cc818

• Scale internal times for Job objects.

  jcoupey

  committed
  43ac60c

  Copy full SHA for 43ac60c

• Scale times back to seconds in Solution objects.

  jcoupey

  committed
  17d73ea

  Copy full SHA for 17d73ea

• Use custom types in CostWrapper.

  jcoupey

  committed
  82bf38a

  Copy full SHA for 82bf38a

• Switch to uint64_t for Cost and Duration.

  jcoupey

  committed
  6d38cc6

  Copy full SHA for 6d38cc6

• Factor max travel time checks in a single Vehicle member function.

  jcoupey

  committed
  6b6e21a

  Copy full SHA for 6b6e21a

• Fix problem with glpk when using max uint64_t value.

  jcoupey

  committed
  eb325cc

  Copy full SHA for eb325cc

Commits on Nov 18, 2022

• Avoid overflow using INFINITE_COST.

  jcoupey

  committed
  2988ac0

  Copy full SHA for 2988ac0

Commits on Nov 20, 2022

• Return a SignedCost for get_cost_upper_bound.

  jcoupey

  committed
  cf81e50

  Copy full SHA for cf81e50

Commits on Nov 21, 2022

• Merge branch 'master' into refactor/cost-wrapper

  jcoupey

  committed
  777637f

  Copy full SHA for 777637f

• Introduce new UserCost and UserDuration types.

  jcoupey

  committed
  8c8ab55

  Copy full SHA for 8c8ab55

• Replace SignedCost with Cost as int64_t.

  jcoupey

  committed
  cbab520

  Copy full SHA for cbab520

• Replace SignedDuration with Duration as int64_t.

  jcoupey

  committed
  e215b61

  Copy full SHA for e215b61

• Add helper function to scale UserDuration values.

  jcoupey

  committed
  c72838d

  Copy full SHA for c72838d

• Store cost upper bound as Cost.

  jcoupey

  committed
  5c55386

  Copy full SHA for 5c55386

• Scale back to UserDuration within choose_ETA for plan mode.

  jcoupey

  committed
  b6adeb6

  Copy full SHA for b6adeb6

• Scale back to UserDuration within format_route.

  jcoupey

  committed
  1ca6613

  Copy full SHA for 1ca6613

• Cleanup leftover macro.

  jcoupey

  committed
  c7c1b80

  Copy full SHA for c7c1b80

• Update changelog.

  jcoupey

  committed
  c337449

  Copy full SHA for c337449

• Fix libvroom example build.

  jcoupey

  committed
  53031bb

  Copy full SHA for 53031bb

• Cleanup format_route asserts.

  jcoupey

  committed
  f47a036

  Copy full SHA for f47a036

Commits on Nov 22, 2022

• Adjust waiting times to avoid rounding problems and add back some asserts.

  jcoupey

  committed
  219d761

  Copy full SHA for 219d761

• Assert UserDuration consistency at route level.

  jcoupey

  committed
  5106abe

  Copy full SHA for 5106abe

• Compute steps durations in a consistent way as seen from UserDuration.

  jcoupey

  committed
  ed6242c

  Copy full SHA for ed6242c

• Pass adjusted waiting_time value to Route ctor.

  jcoupey

  committed
  efb984d

  Copy full SHA for efb984d

Commits on Nov 23, 2022

• Same kind of route formatting adjustments for plan mode.

  jcoupey

  committed
  90b72cd

  Copy full SHA for 90b72cd

• Make CostWrapper a class and merge set_costs_factor and set_costs_matrix.

  jcoupey

  committed
  ed71664

  Copy full SHA for ed71664

• Add flag to track whether Cost and Duration are the same in CostWrapper.

  jcoupey

  committed
  ac9ae7e

  Copy full SHA for ac9ae7e

• Make sure reported cost and duration are consistent when necessary.

  jcoupey

  committed
  0d213aa

  Copy full SHA for 0d213aa

• Add consistency checks at step level in vroom::Route.

  jcoupey

  committed
  b9b649a

  Copy full SHA for b9b649a

• Use regular setup/service values when formatting RawRoute.

  jcoupey

  committed
  9db94d0

  Copy full SHA for 9db94d0

• Scale setup back when formatting RawRoute.

  jcoupey

  committed
  0aeb03c

  Copy full SHA for 0aeb03c