Merge pull request #428 from rebornix/Fix#369

Fix#369. `dw` eats EOF.
VSCodeVim · Jul 12, 2016 · c2ff2fb · c2ff2fb
2 parents 1bc94f4 + 4aa1c55
commit c2ff2fb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/actions/actions.ts b/src/actions/actions.ts
@@ -1512,8 +1512,8 @@ export class MoveWordBegin extends BaseMovement {
     next line.
     */
 
-    if (result.isLineBeginning()) {
-        return result.getLeftThroughLineBreaks();
+    if (result.line > position.line + 1 || (result.line === position.line + 1 && result.isFirstWordOfLine())) {
+      return position.getLineEnd();
     }
 
     if (result.isLineEnd()) {

diff --git a/src/motion/position.ts b/src/motion/position.ts
@@ -369,6 +369,10 @@ export class Position extends vscode.Position {
         return this.character >= Position.getLineLength(this.line);
     }
 
+    public isFirstWordOfLine(): boolean {
+        return Position.getFirstNonBlankCharAtLine(this.line) === this.character;
+    }
+
     public isAtDocumentEnd(): boolean {
         return this.line === TextEditor.getLineCount() - 1 && this.isLineEnd();
     }

diff --git a/test/mode/modeNormal.test.ts b/test/mode/modeNormal.test.ts
@@ -63,6 +63,20 @@ suite("Mode Normal", () => {
       end: ["one| "],
     });
 
+    newTest({
+      title: "Can handle dw across lines",
+      start: ['one |two', '  three'],
+      keysPressed: 'dw',
+      end: ["one| ", "  three"]
+    });
+
+    newTest({
+      title: "Can handle dw across lines",
+      start: ['one |two', '', 'three'],
+      keysPressed: 'dw',
+      end: ["one| ", "", "three"]
+    });
+
     newTest({
       title: "Can handle dd last line",
       start: ['one', '|two'],