fix #922 (#960)

VSCodeVim · Oct 21, 2016 · c58f7af · c58f7af
1 parent 321fd33
commit c58f7af
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/actions/actions.ts b/src/actions/actions.ts
@@ -2153,9 +2153,16 @@ export class PutCommandVisual extends BaseCommand {
   canBePrefixedWithDot = true;
 
   public async exec(position: Position, vimState: VimState, after: boolean = false): Promise<VimState> {
-    const result = await new DeleteOperator().run(vimState, vimState.cursorStartPosition, vimState.cursorPosition, false);
+    let start = vimState.cursorStartPosition;
+    let end = vimState.cursorPosition;
 
-    return await new PutCommand().exec(vimState.cursorStartPosition, result, true);
+    if (start.isAfter(end)) {
+      [start, end] = [end, start];
+    }
+
+    const result = await new DeleteOperator().run(vimState, start, end, false);
+
+    return await new PutCommand().exec(start, result, true);
   }
 
   // TODO - execWithCount

diff --git a/test/mode/modeNormal.test.ts b/test/mode/modeNormal.test.ts
@@ -1095,6 +1095,13 @@ suite("Mode Normal", () => {
       end: ["abc abc |dhi"]
     });
 
+    newTest({
+      title: "can handle p with selection",
+      start: ["one", "two", "|three"],
+      keysPressed: "yykVkp",
+      end: ["|three", "three"]
+    });
+
     newTest({
       title: "can handle P with selection",
       start: ["|abc def ghi"],