Merge pull request #1567 from xconverge/add-blackhole-register

fixes #1357
VSCodeVim · Apr 25, 2017 · f3ad12c · f3ad12c
2 parents a725d0d + 558686e
commit f3ad12c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/register/register.ts b/src/register/register.ts
@@ -38,6 +38,7 @@ export class Register {
     '.': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false },
     '*': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: true },
     '+': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: true },
+    '_': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false },
     '0': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false },
     '1': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false },
     '2': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false },
@@ -50,6 +51,9 @@ export class Register {
     '9': { text: "", registerMode: RegisterMode.CharacterWise, isClipboardRegister: false }
   };
 
+  public static isBlackHoleRegister(registerName: string): boolean {
+    return (registerName === "_");
+  }
 
   public static isClipboardRegister(registerName: string): boolean {
     const register = Register.registers[registerName];
@@ -90,6 +94,10 @@ export class Register {
       throw new Error(`Invalid register ${register}`);
     }
 
+    if (Register.isBlackHoleRegister(register)) {
+      return;
+    }
+
     if (vimState.isMultiCursor) {
       if (Register.isValidUppercaseRegister(register)) {
         Register.appendMulticursorRegister(content, register, vimState, multicursorIndex as number);
@@ -243,6 +251,10 @@ export class Register {
       util.clipboardCopy(content.toString());
     }
 
+    if (Register.isBlackHoleRegister(register)) {
+      return;
+    }
+
     Register.registers[register] = {
       text               : content,
       registerMode       : registerMode || RegisterMode.FigureItOutFromCurrentMode,

diff --git a/test/register/register.test.ts b/test/register/register.test.ts
@@ -51,6 +51,13 @@ suite("register", () => {
     end: ["one", "two", "one", "|two"],
   });
 
+  newTest({
+    title: "Can use black hole register",
+    start: ['|asdf', "qwer"],
+    keysPressed: 'yyj"_ddkp',
+    end: ["asdf", "|asdf"],
+  });
+
   test("System clipboard works with chinese characters", async () => {
     const testString = '你好';
     util.clipboardCopy(testString);