Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #17

Closed
adriaanp opened this issue Nov 19, 2015 · 9 comments
Closed

Contributing #17

adriaanp opened this issue Nov 19, 2015 · 9 comments

Comments

@adriaanp
Copy link
Contributor

Was going to do an extension myself, would love to contribute.

Are you guys starting from a reference project or from scratch? I was thinking of porting the atom vim-mode extension to vscode.

@jpoon
Copy link
Member

jpoon commented Nov 19, 2015

@adriaanp that would be awesome! I've been using atom/vim-mode as an inspiration for the command/insert mode work, but haven't been porting it directly.

@adriaanp
Copy link
Contributor Author

Any idea on what I can work and focus on?

@jpoon
Copy link
Member

jpoon commented Nov 19, 2015

We should probably get a bit more organized and make a task list of things we need to do.

I've been working on the basics of the different modes and a bit of the navigation keys within command mode: #16. No work yet has been done with the visual mode. @guillermooo has been working on the command console (e.g. :wq).

Feel free to party 🎉 on whatever you think we're missing or most pressing.

@ahmedshuhel
Copy link

@jpoon I would like to contribute too. I tried atom/vim-move earlier and found it to be unusable most of the time. I don't know why, may be because atom is slow in general. If your experience is same, we have to be careful about it.

@jpoon
Copy link
Member

jpoon commented Nov 20, 2015

Feel free to implement your favorite VI command.

I just merged the toggling between various modes: command, insert, visual with the following keybindings:

  • Command Mode: h,j,k,l (navigation)
  • Insert Mode: a, A, i, I, o, O

We also need to make everything more testable. That might mean setting up a pattern for testing VSCode UI (ie. where the current cursor is, the status bar item) or mocking everything out.

A quick one might be to figure out how to publish this to the extension gallery.

@gosukiwi
Copy link

Not sure where to put this, but I find Visual Blockwise Mode quite important. I know the implementation should be hard, atom's vim-mode doesn't support it.

Any plans for adding that feature?

@DennyScott
Copy link

Hey guys, I've been working on a previous vim project for vsc, but your guys project looks really promising! I've ported over most of the selection mode over from atom-vim, what state is selection mode in currently? I can try integrating them :).

@jpoon
Copy link
Member

jpoon commented Dec 1, 2015

@DennyScott we have nothing atm for selection mode. Most of the effort has been with command mode and handling the various commands :wq etc. Feel free to help with selection/visual mode.

@jpoon
Copy link
Member

jpoon commented Dec 4, 2015

We now have a contributing.md so please refer to that on how to get started.

@jpoon jpoon closed this as completed Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants