Command/Insert Modes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handles 'i' and 'I' to insert * able to toggle between command (esc) and insert (w/ i or I)
Closed
|
One thing to keep in mind if that Vim uses key names like |
|
I would suggest that we register the commands as "vsc_vim.a" instead of "extension.vimMode_a" What do you guys think? |
Conflicts: test/scanner.test.ts
|
@adriaanp Absolutely. I'll do that. Update: After taking a look at the other VSCode implemented commands, they keep things neat and tidy under namespaces (editor, etc). I think I'll keep with this convention but shorten it to |
jpoon
force-pushed
the
insert-mode
branch
4 times, most recently
from
4453c35 to
d30450c
Compare
* Toggling between modes using 'esc' and insert keys Supported Commands: Insert Mode - i, I, a, A, o, O Command Mode - h, j, k, l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Ready to merge.
With this PR, implements basic key bindings in the various modes and ability to toggle between
escand insert keysSupported Commands:
The current mode is displayed at the bottom left status bar.
Somewhat addresses #13