Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binding letter sequence to ESC in OtherModes #1883

Closed
pciazynski opened this issue Jun 28, 2017 · 0 comments · Fixed by #4735
Closed

Support binding letter sequence to ESC in OtherModes #1883

pciazynski opened this issue Jun 28, 2017 · 0 comments · Fixed by #4735

Comments

@pciazynski
Copy link

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Environment:

  • VSCode Version: 1.13.1
  • VsCodeVim Version: 0.9.0
  • OS: Ubuntu 16.04

What happened:
I try to bind jk to <ESC>:

"vim.otherModesKeyBindingsNonRecursive": [       
  {
    "before": [ "j", "k" ],
    "after": [ "<Esc>" ]
  }
]

but this doesn't work. jk does nothing in Visual Mode.

What did you expect to happen:
Because I have binding jk to leave Insert Mode I would like also have possibility to escape Visual Mode with jk, but this doesn't work.

How to reproduce it:
Paste above snipper into your settings.json, go to Visual Mode and press jk. Unfortunately nothing happen, we will stay in Visual Mode.

@berknam berknam mentioned this issue May 13, 2020
10 tasks
J-Fields pushed a commit that referenced this issue Aug 16, 2020
This is a pretty massive change; see pull request #4735 for full details

Most notably:
- Support for operator-pending mode, including remaps and a half-cursor decoration
- Correct handling of ambiguous remaps with timeout
- Correct handling of recursive special case when the RHS starts with the LHS
- Correct handling of multi-key remaps in insert mode
- Failed movements that occur partway through a remap stop & discard the rest of the remap
- Implement `unmap` and `mapclear` in .vimrc

Refs #463, refs #4908
Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835
Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466
Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086
Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768
Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353
Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674
Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016
Fixes #5057, fixes #5067, fixes #5084, fixes #5125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant