Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape replace mode with <C-[> #2221

Closed
deybhayden opened this issue Dec 14, 2017 · 1 comment
Closed

Escape replace mode with <C-[> #2221

deybhayden opened this issue Dec 14, 2017 · 1 comment
Labels
help wanted kind/enhancement size/XS

Comments

@deybhayden
Copy link
Contributor

Vim/src/actions/commands/actions.ts

Line 529 in 113dd77

keys = [['<Esc>'], ['<C-c>']];

Hey there, is it reasonable to add <C-[> to the CommandEscReplaceMode.keys array? Don't know if it's just an oversight of if there's a Vim or VS Code reason not to.
@jpoon
Copy link
Member

jpoon commented Dec 14, 2017

Oversight. Feel free to submit a PR.

@deybhayden deybhayden mentioned this issue Dec 14, 2017
Merged
jpoon pushed a commit that referenced this issue Dec 14, 2017
@deybhayden @jpoon
Add C-[ to Replace Mode escape
9b1e987 
Closes #2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted kind/enhancement size/XS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpoon @deybhayden