"," cannot be remapped when {"vim.leader": ","}

[haberdashPI]

Describe the bug
If you remap the leader to "," there's no way to reference the old functionality of ",".

To Reproduce
Replace settings.json with the following text:

{
  "vim.leader": ",",
  "vim.normalModeKeyBindingsNonRecursive": [
        {
            "before": ["^"],
            "after": [","]
        }
    ],
}

Place the following text in a new file

testing testing testing

Place the cursor on the start of the line. In insert mode, "fe;" will jump to the first "e" and then the second "e". Now press "^". Nothing will happen.

(Note: "^" also does not act as a leader. Commands I've mapped to leader do not work when using "^" in the above scenario).

Expected behavior

I would expect that pressing "^" would move the cursor back to the first "e" in the above example.

Environment (please complete the following information):

• Extension (VsCodeVim) version: 0.15.7
• VSCode version: 1.25.1
• OS: Mac OS X 10.11.6

[jpoon]

Related: #2735

[jpoon]

I think you meant to swap the before and after in your configuration.

The PR fixes the above issue but exposes a larger issue. As we don't do any look-ahead, if there is an immediate matching action for the key, the extension will immediately execute it. For instance, if you bind your leader key to an existing VIM key (e.g. ,), when you have remappings such as:

before: , f, e, s
after: v

When you press , (which is the leader key), we will immediately execute:

Vim/src/actions/motion.ts

Line 749 in 9cff13d

class MoveRepeatReversed extends BaseMovement {

and not wait for further keys.

[haberdashPI]

Interesting, I misunderstood the meaning of "before" and "after" here.

Thanks for your work and energy looking into this. I'm eagerly awaiting a fix of the larger issue.

[jpoon]

I'm going to close this as a dupe of #1821 as it's the same root cause.