Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gf: 'try to find it with the same extension'-code doesn't work #3310

Closed
pikulev opened this issue Dec 30, 2018 · 3 comments · Fixed by #3311
Closed

gf: 'try to find it with the same extension'-code doesn't work #3310

pikulev opened this issue Dec 30, 2018 · 3 comments · Fixed by #3311
Labels
status/duplicate

Comments

@pikulev
Copy link
Contributor

pikulev commented Dec 30, 2018

Describe the bug

gf under the require('some_file') in .js file says "Vim: This file /Users/vvp/test/some_file.js does not exist.".

To Reproduce
Steps to reproduce the behavior:

  1. echo '// some_file' > file.js && touch some_file.js
  2. code file.js
  3. gf under the some_file
  4. See error

Expected behavior
some_file.js has opened

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.17.3
  • VSCode version: 1.30.1
  • OS: Mac OS 10.13.4
pikulev added a commit to pikulev/Vim that referenced this issue Dec 30, 2018
@pikulev
fix: gf under the file:// path and VSCodeVim#3310 issue
01e0125
This was referenced Dec 30, 2018
Merged
Closed
@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

Dupe of #3233?

@pikulev
Copy link
Contributor Author

pikulev commented Dec 30, 2018 •
edited
Loading

Dupe of #3233?

Seems to be a dup, yes.

@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

Cool cool. Let's use that one.

@jpoon jpoon closed this as completed Dec 30, 2018
jpoon added a commit that referenced this issue Jan 20, 2019
@jpoon
fix: address 'gf' bug. closes #3310
3ee835b
@jpoon jpoon mentioned this issue Jan 20, 2019
Merged
jpoon added a commit that referenced this issue Jan 20, 2019
@jpoon
fix: address 'gf' bug. closes #3310
895dc5f
jpoon added a commit that referenced this issue Jan 20, 2019
@jpoon
Merge pull request #3396 from VSCodeVim/BRANCHNAME
c3c80e2 
fix: gf over a 'file://...' path and #3310 issue (v2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: gf over a 'file://...' path and #3310 issue pikulev/Vim
2 participants
@jpoon @pikulev