Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.0.4 doesn't contain listed changes #3429

Closed
pikulev opened this issue Jan 31, 2019 · 5 comments
Closed

Release 1.0.4 doesn't contain listed changes #3429

pikulev opened this issue Jan 31, 2019 · 5 comments
Labels
kind/bug

Comments

@pikulev
Copy link
Contributor

pikulev commented Jan 31, 2019

Describe the bug
I checked the Release 1.0.4 Source code (zip) and it doesn't contain changes related to the #3402 PR

screenshot 2019-01-31 at 11 59 29
@jpoon
Copy link
Member

jpoon commented Jan 31, 2019 •
edited
Loading

What do you mean? As in you are able to repro the issue?

@pikulev
Copy link
Contributor Author

pikulev commented Jan 31, 2019 •
edited
Loading

@jpoon yes, I am able to repro the issue. It seems like the published release wasn't from the latest master commit :-/

@jpoon
Copy link
Member

jpoon commented Jan 31, 2019

Interesting, you're right. I don't know how that could have happened though as the tag was produced from #3427.

jpoon added a commit that referenced this issue Jan 31, 2019
@jpoon
feat: output commit hash. closes #3429
6aaef99
@jpoon
Copy link
Member

jpoon commented Jan 31, 2019

Pushing a v1.0.5 release

@jpoon jpoon mentioned this issue Jan 31, 2019
Merged
jpoon added a commit that referenced this issue Jan 31, 2019
@jpoon
feat: output commit hash. closes #3429
6a8e56d
@jpoon
Copy link
Member

jpoon commented Jan 31, 2019

v1.0.5 looks right.

@jpoon jpoon closed this as completed in 1b040f2 Jan 31, 2019
jpoon added a commit that referenced this issue Jan 31, 2019
@jpoon
Merge pull request #3430 from VSCodeVim/commit-hash
e6e55ba 
feat: output commit hash. closes #3429
@jpoon jpoon added the kind/bug label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpoon @pikulev