-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:o fails in remote SSH #3815
Comments
Tab completion for :e error out the same way with remote ssh session as well |
#3639 |
I looked more into this, and I think this is because the Vim extension is running on the local machine which doesn't have the access of the remote file system and failed at https://github.com/VSCodeVim/Vim/blob/master/src/actions/commands/actions.ts#L1979 EDIT: Maybe using vscode api instead of directly using fs would work? EDIT 2: I don't think that findFiles API would work for remote, and there seems to be a proposed API to access file system with any scheme. |
I just tested the proposed API. It works for any file connecting scheme like remote ssh. |
This commit refactors the existing auto complete mechanism to be more consistent with the actual Vim while adding support for VS Code Remote. Fixes VSCodeVim#3815
This commit refactors the existing auto complete mechanism to be more consistent with the actual Vim while adding support for VS Code Remote. Fixes VSCodeVim#3815
This commit refactors the existing auto complete mechanism to be more consistent with the actual Vim while adding support for VS Code Remote. Fixes VSCodeVim#3815
* Only untidify when it is a local fs * Trim the command before running This is to allow command with extra spaces in front and back to run * Fix existing auto completion test * Add remote file completion This commit refactors the existing auto complete mechanism to be more consistent with the actual Vim while adding support for VS Code Remote. Fixes #3815 * Add more tests to increase tab-completion coverage * Use untitled document for nonexisting file path in cmd In the actual Vim, commands like ":e" do not create a file first if the path in the cmd doesn't exist. Rather, it creates an empty buffer and only create the file on write. This commits changes the behavior to be more consistent with actual Vim by using untitled document instead creating the file if the file on the cmd is not found. * Update according to the comments * Revert CommandGoToDefinition to master * Remove the addition line breaks added * Refactor and address comments * Call <Esc> to clean up test * Exceute <Esc> cleanup in finally * Revert "Exceute <Esc> cleanup in finally" This reverts commit aeb70ae. * replace afterEach with teardown
Describe the bug
When I connect to a remote SSH host using Remote-SSH, using :o and then hitting tab for autocomplete results in:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Environment (please complete the following information):
Additional context
Note that the SSH remote is Ubuntu, could be a contributing issue.
The text was updated successfully, but these errors were encountered: