Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[End of line] - mouse selection skip last character (edge case) #4039

Closed
uglyboxer opened this issue Sep 4, 2019 · 2 comments · May be fixed by #5842
Closed

[End of line] - mouse selection skip last character (edge case) #4039

uglyboxer opened this issue Sep 4, 2019 · 2 comments · May be fixed by #5842
Assignees
@J-Fields
Labels
area/selection kind/bug

Comments

@uglyboxer
Copy link

Describe the bug
When in vim 'Normal' mode, if the cursor is on the last character of a line, selecting with with a mouse omits the last character (the one before the newline).

To Reproduce
Steps to reproduce the behavior:

  1. Enter 'Normal' mode
  2. Navigate to last character of a line of text
  3. Select that line with the mouse
  4. Last character (before the newline) will not be in the selection

Screenshots

Environment (please complete the following information):

VSCodeVim 1.10.2
VSCode 1.37.1
MacOSX 10.14.6 (Mojave)

Link to related issue
@J-Fields J-Fields self-assigned this May 22, 2020
@J-Fields J-Fields mentioned this issue Jun 23, 2020
Open
@ryandanielspmc
Copy link

This is a very annoying problem.

berknam added a commit to berknam/Vim that referenced this issue Dec 7, 2020
@berknam
Fix mouse selection not selecting last character of line
5d1a98a 
- fixes VSCodeVim#4039, fixes VSCodeVim#3260
@berknam berknam mentioned this issue Dec 7, 2020
Open
10 tasks
berknam added a commit to berknam/Vim that referenced this issue Jan 16, 2021
@berknam
Fix mouse selection not selecting last character of line
1e0984b 
- fixes VSCodeVim#4039, fixes VSCodeVim#3260
@moh682
Copy link

moh682 commented Feb 12, 2021

Please fix the problem. berknam has a PR that looks like will do. Can someone test it ?

@tbm98 tbm98 mentioned this issue Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-Fields J-Fields

Labels
area/selection kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Select mode implementation with keymodel and selectmode settings berknam/Vim
4 participants
@uglyboxer @J-Fields @moh682 @ryandanielspmc