2x, 2s doesn't work

[octref]

No effect when pressing 2x or 2s.

• VSCode Version: 1.7
• VsCodeVim Version: 0.3.8
• OS: OS X 10.11.6

[rebornix]

I can't repro this issue, neither can @xconverge . I'll have a quick check with you tomorrow.

[octref]

Here are the error when I do 2s or 2x

shell.ts:442 Overlapping ranges are not allowed!: Error: Overlapping ranges are not allowed!
    at t.applyEdits (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:56:17157)
    at e.pushEditOperation (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:39:24298)
    at file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:56:15362
    at i (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:29:22509)
    at t.e.deferredEmit (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:29:25586)
    at t.pushEditOperations (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:56:14492)
    at t.executeEdits (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:61:17739)
    at e.applyEdits (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:78:12694)
    at t.$tryApplyEdits (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:100:31521)
    at t.e.handle (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:100:9689)

Can you try this repro:

1. Open new editor

2. Paste

     private onFoo() {
     }
   

3. Put cursor in here private |onFoo() {

4. Do 2s

[johnfn]

Strange, it works fine for me (even your provided example).

[octref]

OK. I can't repro with my own example anymore 😂

I can still make this bug happen it in one of my file. Let me show @rebornix tomorrow.

[rebornix]

The last call in Code we saw is applyEdit and it's saying we are editing against ranges which have overlap. I have a feeling that our postponed transformation lead to this problem as it's executed in parallel but I still need to dig into the code to see if that's the case.

[rebornix]

We did the wrong overlap checking, which finally leads to the parallel execution of operations, which finally causes this bug.

@octref you are an insanely awesome bug hunter.