-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "d" and "D" in multicursor mode #1029
Conversation
@Platzer same problem on my PR as well |
Apologies for the delayed review/response. Any chance you can add tests around this? Thanks. |
Yeah, my bad for not getting to this earlier. The failing test concerns me. If you can figure that one out (and yeah add another test maybe?) this should be good to go. |
I'm actually not sure if this was necessary; I think the bug ended up being somewhere else. Can you check what's currently on master and see if this change is required? |
@johnfn, the deleting part is fixed in current release but putting into multi cursor register is still broken! would be fixed with this PR. I will try to have a look this week! |
@johnfn, travis is failing cause some npm stuff, but tests are okay. |
Sorry for taking so long on this, @Platzer. I've merged it in now. |
In Multi-Cursor mode "d" in Visual Mode and "D" in Normal-Mode is not working.
Added the current multicursorindex to the
Register.Put
method.