Fix autoindent when opening a line above

[inejge]

Re #862. I rewrote CommandInsertNewLineAbove to mirror CommandInsertNewLineBefore, just using editor.action.insertLineBefore as the editor command to execute.

[inejge]

I don't really understand the test failure on first glance, will investigate later.

[xconverge]

Well if you do a git blame you will get to the reasoning here

#1172

Can you just change the diff to do the indenting correctly?

instead of

diff: new PositionDiff(-1, 0),

do

diff: new PositionDiff(-1, charPositionItShouldBeDueToIndentation),

[johnfn]

I think we have a method on TextEditor to determine correct indentation.

[inejge]

Can you just change the diff to do the indenting correctly?

Just repositioning is not enough, a properly indented empty line must be inserted for this to work. I've changed the patch accordingly (the gymnastics with replace after setIndentationLevel are necessary because the latter doesn't want to indent a string consisting of a bare "\n" and keep the newline).

When invoking O for the first time, i get "invalid value for set cursor position..." in the console.

The tests are still failing for reasons I don't understand -- they're failing for me even without the patch.

[xconverge]

The failing test is unrelated, not sure what is going on there, this LGTM now

[xconverge]

An o and O test that check indentation would be great

[johnfn]

This LGTM to me as well. Thank you for the PR, @inejge (and apologies for the slow responses this month!)