D in visual mode behaves like d #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the earlier Code. Should have created a new branch for the first one as well :) |
|
Nice, mind adding a test to the bottom of modeVisual.test.ts? you can use newTestOnly() to run just the test that you are making, then you can switch it back to newTest() before you commit so that all tests still run |
|
Awesome! |
johnfn
reviewed
Feb 15, 2017
| @@ -696,7 +696,9 @@ export class CommandOneNormalCommandInInsertMode extends BaseCommand { | |||
|
|
|||
| public async exec(position: Position, vimState: VimState): Promise<VimState> { | |||
| vimState.returnToInsertAfterCommand = true; | |||
| return await new CommandEscInsertMode().exec(position, vimState); | |||
| return await new CommandEscInsertMode().exec( | |||
There was a problem hiding this comment.
I don't think that this bit is relevant to the D fix, right? Could you remove it and include it in a separate PR?
There was a problem hiding this comment.
Wait nevermind, it doesn't really matter heh.
|
Excellent, and tests too. Awesome job. Thanks for the PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete function of the DeleteOperation Class already account for this case, if the Register Mode is set to LineWise.