Fixes #1599: dot command doesn't work in macros #1595
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused though. I thought that the problem with #1309 was that macros could cause infinite recursion by calling themselves. How is that related to undo points? Were you referring to a different issue? |
|
Oh sorry, I linked the wrong issue (and I didn't actually fix the issue I meant to link). When trying to fix that issue, I found that it seems to have been fixed at some point (I'm not able to replicate it). However, the dot command still doesn't work properly, because it doesn't do anything in a macro. This fixes that. I'll make a new issue and change my commit or something |
|
@johnfn I added a test that tests the thing I fixed. That should explain the issue I'm trying to fix a bit more. |
|
Alright, got it! Thanks for the PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple. We don't want to prevent us from creating an undo point by setting "runRepeatableAction" to false, we want to prevent us from creating an undo point by checking if we're replaying a macro.
On a related note, I found this issue while trying to fix #1216, which doesn't seem to be an issue anymore.