-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #1642
Refactor #1642
Conversation
rebornix
commented
May 3, 2017
•
edited
Loading
edited
- Move things out of actions.
- Fix diw on trailing whitespace deletes newline #1630
Ping @johnfn @xconverge , jumping inside |
works for me, it seemed to bother people, I don't have strong opinions on it but looks like a good idea! |
Ooh it's happening!!! I am 100% in favor of this. |
I actually started doing this myself, so I could finish it if none of you guys have any particular opinions about how it's done? I was pretty much just planning on separating it similarly to how rebornix was suggesting. |
I think @rebornix's solution of subdividing it into different files within actions.ts is exactly correct. We already have very natural subdivisions for the most part - motions, commands, operators. Motions subdivide into normal motions and text objects. Commands could subdivide into normal mode commands and special insert mode commands. After that we could think about going further if necessary. |
|