-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1684: Fixed gq spacing issues #1686
Conversation
Any chance you can add a gq test to cover this particular issue? |
Yeah I will, in a bit. |
Actually, gq has a couple more bugs I want to fix first. |
wtf. Why does gq take so long. Why do some of the tests take such a ridiculous amount of time to run? Like the comment stuff and the reflow stuff. Either way, the tests work locally. |
Since for w.e. reason, gq tests take forever to run, I'm just gonna remove them. |
@xconverge Oh shit I accidentally added a newTestOnly in my last PR. |
This LGTM, a bit sad about the tests though...o well |
:( @jpoon Any idea why some tests run so much slower on Travis? |
No idea :/. |
I think tests should be able to be sped up significantly tbh. |
I typically do not like seeing commented out tests, but since I asked for them, I think we can leave them for now and if we speed tests up, we can uncomment them The functionality added by the fix makes sense and has been code reviewed atleast |
This should hopefully fix all gq spacing issues.