Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1684: Fixed gq spacing issues #1686

Merged
merged 11 commits into from
May 19, 2017
Merged

Fixes #1684: Fixed gq spacing issues #1686

merged 11 commits into from
May 19, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 11, 2017

This should hopefully fix all gq spacing issues.

@xconverge
Copy link
Member

Any chance you can add a gq test to cover this particular issue?

@Chillee
Copy link
Member Author

Chillee commented May 11, 2017

Yeah I will, in a bit.

@Chillee
Copy link
Member Author

Chillee commented May 14, 2017

Actually, gq has a couple more bugs I want to fix first.

@Chillee
Copy link
Member Author

Chillee commented May 16, 2017

wtf. Why does gq take so long. Why do some of the tests take such a ridiculous amount of time to run? Like the comment stuff and the reflow stuff.

Either way, the tests work locally.

@Chillee
Copy link
Member Author

Chillee commented May 17, 2017

Since for w.e. reason, gq tests take forever to run, I'm just gonna remove them.

@Chillee
Copy link
Member Author

Chillee commented May 17, 2017

@xconverge Oh shit I accidentally added a newTestOnly in my last PR.

@xconverge
Copy link
Member

This LGTM, a bit sad about the tests though...o well

@Chillee
Copy link
Member Author

Chillee commented May 18, 2017

:( @jpoon Any idea why some tests run so much slower on Travis?

@jpoon
Copy link
Member

jpoon commented May 18, 2017

No idea :/.

@Chillee
Copy link
Member Author

Chillee commented May 18, 2017

I think tests should be able to be sped up significantly tbh.

@xconverge xconverge merged commit 4a61033 into VSCodeVim:master May 19, 2017
@xconverge
Copy link
Member

I typically do not like seeing commented out tests, but since I asked for them, I think we can leave them for now and if we speed tests up, we can uncomment them

The functionality added by the fix makes sense and has been code reviewed atleast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants