-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easymotion improvements #2017
Easymotion improvements #2017
Conversation
tweaks Also get foreground color for markers from vscode themecolor
update 1 Extract to createCurrentCommandText method update 2 update 3
I don't know what vscode theme color is good for markers' background and foreground. ExamplesSolarized Dark Theme All available colors are found here. |
Nice! That looks awesome (way better than our current default of red and black...). However, it seems like you've gotten rid of the current method of choosing colors. Would it be possible to only use the background color if the user has not manually chosen his own colors? I am worried that it does limit customizability for those that want it. We're also having some trouble with Travis. I'll take a look tonight. |
This is the function to select color.
This is a customize example with the configuration below. {
"vim.easymotionMarkerForegroundColorOneChar": "#000",
"vim.easymotionMarkerForegroundColorTwoChar": "#000"
} |
@MaxfieldWalker Awesome. So it only uses the theme's settings if those settings aren't manually set? |
@Chillee Yes, exactly. |
Great! I've fixed the Travis issues, so I'll merge this (and some other PR's) and then issue a release tonight! |
@MaxfieldWalker Actually, it seems like an easymotion test is failing, so can you check that? |
Make easymotion work even better.
Improvements
s
mapping for EasyMotion to any surrounding word #1741Fixes