Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #2138

Merged
merged 18 commits into from
Nov 13, 2017
Merged

Code Cleanup #2138

merged 18 commits into from
Nov 13, 2017

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Nov 12, 2017 •
edited
Loading

  • Move EditorIdentity to its own file
  • Simplify configuration class: userCursor configuration with getter. use decorator for handleKeys
  • Fix bug with using default values if no config is found
  • Upgrade clipboardy which includes some windows fixes.
  • Update vscode.workspace.getConfiguration to supply resource URI to get rid of all the crazy warnings
  • Update readme in an attempt to make it more succint as it is a hella long read.

@jpoon jpoon force-pushed the clean-up branch 6 times, most recently from b80db76 to 995f85e Compare November 12, 2017 16:14
@jpoon jpoon force-pushed the clean-up branch 6 times, most recently from 3d321c8 to 09dc6ad Compare November 13, 2017 03:46
@jpoon jpoon force-pushed the clean-up branch 5 times, most recently from 62dda32 to 628f44d Compare November 13, 2017 05:12
@jpoon jpoon force-pushed the clean-up branch 2 times, most recently from 2895953 to 698242a Compare November 13, 2017 05:18
@jpoon
Copy link
Member Author

jpoon commented Nov 13, 2017 •
edited
Loading

@Chillee @xconverge random code refactoring mainly around simplifying configuration and getting rid of the crazy amount of warning messages. If you have no qualms, I'll check this in?

Edit: That big red merge button was too enticing. Let me know if you have concerns though and I can back it out.

@jpoon jpoon merged commit e471388 into master Nov 13, 2017
@jpoon jpoon deleted the clean-up branch November 13, 2017 18:36
@xconverge
Copy link
Member

no qualms :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpoon @xconverge