Fix #2168: Surround offset #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Vim, the commands `yw` and `yaw` will also yank any trailing whitespace. However, during a surround command `ysaw`, we want to exclude that whitespace to avoid an offset.
|
Aghhhh!!! All of these have a space/don't have a space/have a new line at the beginning/end permutations are so annoying to deal with. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the extra whitespace created when the
ysawandyswcommands are used.As explained in 56371b6, this occurs because the
yawandywcommands normally yank the trailing whitespace after the current word. In this surround case, we want to ignore that extra character and modify the ending cursor position accordingly.I have added 6 new tests to cover these scenarios.