moar clean-up #2208
Merged
moar clean-up #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
reviewed
Dec 8, 2017
test/index.ts
Outdated
|
|
||
| var testRunner = require('vscode/lib/testrunner'); | ||
|
|
||
| import Globals from '../src/globals'; | ||
| Globals.isTesting = true; | ||
|
|
||
| // You can directly control Mocha options by uncommenting the following lines |
There was a problem hiding this comment.
maybe delete this first sentence in this comment now? Not sure it makes much sense, the 2nd sentence is still useful
|
lgtm, thanks @jpoon |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up this PR mainly to run tests. Been trying to track down the perf issue, but keep on getting distracted.
Changes: