Fixes #2346 #2347
Merged
Fixes #2346 #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
reviewed
Jan 31, 2018
src/cmd_line/commandLine.ts
Outdated
| true | ||
| ); | ||
| if (e.code === ErrorCode.E492) { | ||
| await Neovim.command(vimState, command); |
There was a problem hiding this comment.
Even for users that haven't configured to use neovim, you want to use neovim as a fallback?
There was a problem hiding this comment.
My bad. You're right, there should be another check here.
Travis tests have failedHey Horace He, Node.js: 8.9.1git ls-tree -r HEAD --name-only | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5gulp |
Travis tests have failedHey Horace He, Node.js: 8.9.1git ls-tree -r HEAD --name-only | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5if [[ $(git diff-index HEAD --) ]]; then ./node_modules/prettier/bin/prettier.js -v; git diff; echo "Prettier Failed. Run `gulp` or `gulp forceprettier`"; exit 1; else echo "Prettier passed."; figulpnpm test --silent; |
Travis tests have failedHey Horace He, Node.js: 8.9.1git ls-tree -r HEAD --name-only | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5if [[ $(git diff-index HEAD --) ]]; then ./node_modules/prettier/bin/prettier.js -v; git diff; echo "Prettier Failed. Run `gulp` or `gulp forceprettier`"; exit 1; else echo "Prettier passed."; figulpnpm test --silent; |
Travis tests have failedHey Horace He, Node.js: 8gulp forceprettiergulpnpm test --silent; |
Travis tests have failedHey Horace He, Node.js: 8gulp forceprettierif [[ $(git diff-index HEAD --) ]]; then git diff; echo "Prettier Failed. Run `gulp` or `gulp forceprettier`"; exit 1; figulp |
|
Finally, it works. I didn't realize Travis built with some version of the main branch merged with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2346 (comment)
explains the problem and the fix.