Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Improvements #2351

Merged
merged 5 commits into from
Feb 4, 2018
Merged

Build Improvements #2351

merged 5 commits into from
Feb 4, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Feb 1, 2018

What this PR does / why we need it:

  • Move to npm for typings. DefinitelyTyped is deprecated.
  • Adds gulp test command which builds a Docker container and runs tests inside that container. Makes it easier to run tests as it doesn't take over existing VS Code instance.

Which issue(s) this PR fixes

Special notes for your reviewer:

@jpoon jpoon changed the title Build Improvements WIP: Build Improvements Feb 1, 2018
@Chillee
Copy link
Member

Chillee commented Feb 1, 2018

LGTM

@jpoon jpoon mentioned this pull request Feb 2, 2018
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Feb 3, 2018
@jpoon jpoon changed the title WIP: Build Improvements Build Improvements Feb 4, 2018
@jpoon jpoon merged commit 8526fd4 into master Feb 4, 2018
@jpoon jpoon deleted the build branch February 4, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants