Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hopefully fixing the rest of our undo issues #2559

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Hopefully fixing the rest of our undo issues #2559

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c81cf3
Removed viewcolumn from editoridentity information
Chillee Apr 23, 2018
9c6cf16
Merge branch 'fixundoissues' of github.com:Chillee/Vim into fixundois…
Chillee Apr 23, 2018
a2086a0
Ran prettier
Chillee Apr 23, 2018
45e8eb2
Merge branch 'master' into fixundoissues
Chillee Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/editorIdentity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,24 @@ import * as vscode from 'vscode';

export class EditorIdentity {
private _fileName: string;
private _viewColumn: vscode.ViewColumn;

constructor(textEditor?: vscode.TextEditor) {
this._fileName = (textEditor && textEditor.document && textEditor.document.fileName) || '';
this._viewColumn = (textEditor && textEditor.viewColumn) || vscode.ViewColumn.One;
}

get fileName() {
return this._fileName;
}

get viewColumn() {
return this._viewColumn;
}

public hasSameBuffer(identity: EditorIdentity): boolean {
return this.fileName === identity.fileName;
}

public isEqual(other: EditorIdentity): boolean {
return this.fileName === other.fileName && this.viewColumn === other.viewColumn;
return this.fileName === other.fileName;
}

public toString() {
return this.fileName + this.viewColumn;
return this.fileName;
}
}