[Fix] Transition between v,V,<C-v> is different with original Vim behavior #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah this is a good one, very easy to see the difference in behavior between vscodevim and normal vim, thanks for the contribution and tests! |
xconverge
reviewed
Apr 29, 2018
test/mode/modeVisual.test.ts
Outdated
| assertEqual(modeHandler.currentMode.name, ModeName.VisualLine); | ||
| }); | ||
|
|
||
| test('<C-v><C-v> will back to normal mode', async () => { |
There was a problem hiding this comment.
Any chance you can switch these to assert that we got into the correct mode as well? Not a big deal but might be a good idea
C-v...assert in visual block, C-v...assert back in normal etc
* `vv` -> normal mode * `VV` -> normal mode * `<C-v><C-v>` -> normal mode * `vV` -> visual line mode * `v<C-v>` -> visual block mode * `Vv` -> visual (char) mode * `V<C-v>` -> visual block mode * `<C-v>v` -> visual (char) mode * `<C-v>V` -> visual line mode
tyru
force-pushed
the
transition-between-v-shiftv-ctrlv
branch
from
38c0dd9 to
8c37beb
Compare
|
Fixed test and previous commit message a bit :) |
|
Thank you! This one is a no brainer! |
|
Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I expect the same behavior as original Vim :)
vv-> normal modeVV-> normal mode<C-v><C-v>-> normal modevV-> visual line modev<C-v>-> visual block modeVv-> visual (char) modeV<C-v>-> visual block mode<C-v>v-> visual (char) mode<C-v>V-> visual line modeWhich issue(s) this PR fixes
I could not find the issue.