Implement "q:" command

extension.ts

@@ -265,6 +265,8 @@ export async function activate(context: vscode.ExtensionContext) {
     }
   }
 
+  CommandLine.SetHistoryDirPath(context.extensionPath);
+
   registerCommand(context, 'toggleVim', async () => {
     configuration.disableExt = !configuration.disableExt;
     toggleExtension(configuration.disableExt);

src/actions/base.ts

@@ -38,6 +38,14 @@ export let compareKeypressSequence = function(one: string[] | string[][], two: s
     );
   };
 
+  const isSingleAlpha = (s: string): boolean => {
+    if (s.length === 1 && (('a' <= s && s <= 'z') || ('A' <= s && s <= 'Z'))) {
+      return true;
+    } else {
+      return false;
+    }
+  };
+
   for (let i = 0, j = 0; i < one.length; i++, j++) {
     const left = one[i],
       right = two[j];
@@ -56,6 +64,13 @@ export let compareKeypressSequence = function(one: string[] | string[][], two: s
       continue;
     }
 
+    if (left === '<alpha>' && isSingleAlpha(right)) {
+      continue;
+    }
+    if (right === '<alpha>' && isSingleAlpha(left)) {
+      continue;
+    }
+
     if (left === '<character>' && !containsControlKey(right)) {
       continue;
     }

src/actions/commands/actions.ts

@@ -371,7 +371,7 @@ class CommandInsertRegisterContentInSearchMode extends BaseCommand {
 @RegisterAction
 class CommandRecordMacro extends BaseCommand {
   modes = [ModeName.Normal, ModeName.Visual, ModeName.VisualLine];
-  keys = ['q', '<character>'];
+  keys = [['q', '<alpha>'], ['q', '<number>']];
 
   public async exec(position: Position, vimState: VimState): Promise<VimState> {
     const register = this.keysPressed[1];
@@ -1714,6 +1714,31 @@ class CommandShowCommandLine extends BaseCommand {
   }
 }
 
+@RegisterAction
+class CommandShowCommandHistory extends BaseCommand {
+  modes = [ModeName.Normal, ModeName.Visual, ModeName.VisualLine, ModeName.VisualBlock];
+  keys = ['q', ':'];
+
+  runsOnceForEveryCursor() {
+    return false;
+  }
+
+  public async exec(position: Position, vimState: VimState): Promise<VimState> {
+    vimState.recordedState.transformations.push({
+      type: 'showCommandHistory',
+    });
+
+    if (vimState.currentMode === ModeName.Normal) {
+      vimState.commandInitialText = '';
+    } else {
+      vimState.commandInitialText = "'<,'>";
+    }
+    vimState.currentMode = ModeName.Normal;
+
+    return vimState;
+  }
+}
+
 @RegisterAction
 class CommandDot extends BaseCommand {
   modes = [ModeName.Normal];

src/cmd_line/commandLine.ts

@@ -8,7 +8,75 @@ import * as parser from './parser';
 import * as util from '../util';
 import { VimError, ErrorCode } from '../error';
 
+class CommandLineHistory {
+  private _history: string[] = [];
+  private _is_loaded: boolean = false;
+  private _filePath: string = '';
+
+  public add(command: string | undefined): void {
+    if (!command || command.length === 0) {
+      return;
+    }
+
+    let index: number = this._history.indexOf(command);
+    if (index !== -1) {
+      this._history.splice(index, 1);
+    }
+    this._history.unshift(command);
+
+    if (this._history.length > configuration.history) {
+      this._history.pop();
+    }
+  }
+
+  public get(): string[] {
+    if (!this._is_loaded) {
+      this.load();
+      this._is_loaded = true;
+    }
+
+    if (this._history.length > configuration.history) {
+      // resize history because "vim.history" is updated.
+      this._history = this._history.slice(0, configuration.history);
+      this.save();
+    }
+
+    return this._history;
+  }
+
+  public setFilePath(filePath: string): void {
+    this._filePath = filePath;
+  }
+
+  private load(): void {
+    const fs = require('fs');
+
+    if (!fs.existsSync(this._filePath)) {
+      return;
+    }
+
+    try {
+      let data = fs.readFileSync(this._filePath, 'utf-8');
+      let parsedData = JSON.parse(data);
+      if (Array.isArray(parsedData)) {
+        this._history = parsedData;
+      } else {
+        console.log('CommandLine: Failed to load history.');
+      }
+    } catch (e) {
+      console.error(e);
+    }
+  }
+
+  public save(): void {
+    const fs = require('fs');
+    fs.writeFileSync(this._filePath, JSON.stringify(this._history), 'utf-8');
+  }
+}
+
 export class CommandLine {
+  private static _history: CommandLineHistory = new CommandLineHistory();
+
   public static async PromptAndRun(initialText: string, vimState: VimState): Promise<void> {
     if (!vscode.window.activeTextEditor) {
       console.log('CommandLine: No active document.');
@@ -20,6 +88,9 @@ export class CommandLine {
       cmd = cmd.slice(1);
     }
 
+    this._history.add(cmd);
+    this._history.save();
+
     await CommandLine.Run(cmd!, vimState);
   }
 
@@ -66,4 +137,29 @@ export class CommandLine {
       ],
     };
   }
+
+  public static async ShowHistory(
+    initialText: string,
+    vimState: VimState
+  ): Promise<string | undefined> {
+    if (!vscode.window.activeTextEditor) {
+      console.log('CommandLine: No active document.');
+      return '';
+    }
+
+    this._history.add(initialText);
+
+    let cmd = await vscode.window.showQuickPick(this._history.get(), {
+      placeHolder: 'Vim command history',
+      ignoreFocusOut: false,
+    });
+
+    return cmd;
+  }
+
+  public static SetHistoryDirPath(historyDirPath: string): void {
+    const path = require('path');
+    const filePath: string = path.join(historyDirPath, '.cmdline_history');
+    this._history.setFilePath(filePath);
+  }
 }

src/mode/modeHandler.ts

@@ -911,6 +911,14 @@ export class ModeHandler implements vscode.Disposable {
           this.updateView(this.vimState);
           break;
 
+        case 'showCommandHistory':
+          let cmd = await CommandLine.ShowHistory(vimState.commandInitialText, this.vimState);
+          if (cmd && cmd.length !== 0) {
+            await CommandLine.PromptAndRun(cmd, this.vimState);
+            this.updateView(this.vimState);
+          }
+          break;
+
         case 'dot':
           if (!vimState.globalState.previousFullAction) {
             return vimState; // TODO(bell)

src/transformations/transformations.ts

@@ -188,6 +188,13 @@ export interface ShowCommandLine {
   type: 'showCommandLine';
 }
 
+/**
+ * Represents pressing ':'
+ */
+export interface ShowCommandHistory {
+  type: 'showCommandHistory';
+}
+
 /**
  * Represents pressing '.'
  */
@@ -234,6 +241,7 @@ export type Transformation =
   | DeleteTextTransformation
   | MoveCursorTransformation
   | ShowCommandLine
+  | ShowCommandHistory
   | Dot
   | Macro
   | ContentChangeTransformation