Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for quickpick commandline usage #2781

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Allow for quickpick commandline usage #2781

merged 3 commits into from
Jul 3, 2018

Conversation

xconverge
Copy link
Member

fixes #2773

@jpoon I think that this doesn't add too much to maintain and was functionality that existed before

@jpoon
Copy link
Member

jpoon commented Jun 27, 2018

I'm still of the position that we shouldn't do this considering there won't be feature parity between status bar commands vs input box commands. If we do this, we should re-open #779.

{
"key": "shift+;",
"command": "vim.showQuickpickCmdLine",
"when": "inZenMode && vim.mode != 'Insert'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When and where is this context variable being set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cool.

@jpoon
Copy link
Member

jpoon commented Jun 27, 2018

Another possible feature disparity between the two: #745

@hastebrot
Copy link

I'm completely ok with this PR. It allows me to configure key-bindings for my use-case. If I really want to have command history, I can fallback to the default and activate the status bar and leave zen-mode.

README.md Outdated
@@ -597,6 +597,25 @@ Are you on a Mac? Did you go through our [mac-setup](#mac-setup) instructions?

Press `shift+<esc>` to close all of those boxes.

### How can I use the commandline when in Zen mode or when the status bar is disabled?

This extension registers a command pallete of visual studio code exists to show a quickpick version of the commandline. This can be remapped as follows in visual studio keybindings.json settings file.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix grammar in this sentence

@jpoon
Copy link
Member

jpoon commented Jul 3, 2018

So what's the verdict with this PR @xconverge?

@xconverge xconverge merged commit 073e950 into VSCodeVim:master Jul 3, 2018
@xconverge xconverge deleted the config-for-quickpick-commandline branch July 3, 2018 22:15
@mindgitrwx
Copy link

Is it updated properly? I reinstalled vim plugin and reopen, but nothing have been happened.

When I typed command shift + ;, It always brings me messageslike this: 'vim.showQuickPickCmdLine' not found

@jpoon
Copy link
Member

jpoon commented Jul 4, 2018

It's not released yet. https://github.com/VSCodeVim/Vim/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Add an option to bring commandline back to old place
4 participants