-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gulp release #2841
gulp release #2841
Conversation
Travis tests have failedHey @jpoon, Node.js: 8npm run build
|
Travis tests have failedHey @jpoon, Node.js: 8npm run build
|
Is there a way to add a custom part to the changelog with this workflow? |
No, it's all automated and driven from the GitHub issues. |
gulpfile.js
Outdated
|
||
var options = minimist(process.argv.slice(2), releaseOptions); | ||
|
||
if (!options.githubToken) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance you can make this take an environment variable too if the argument is not defined? It is not a big deal but I had been using CHANGELOG_GITHUB_TOKEN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Looks good to me, my only concern is the lack of an ability to add even a single sentence to a changelog. Breaking changes and big changes then cannot be mentioned clearly. |
All driven through labels. So if you add a "backwards-incompatible" label, it'll put it in the "breaking changes" section. Similar with enhancements/features vs bugs. |
What this PR does / why we need it:
Migrates to gulp 4.0 and introduces
gulp release
command which will:Example usage:
Once run, to push a release to remote:
git push --follow-tags
.In the migration to gulp4.0, simplified some of the gulp tasks, we now have the following:
Introduced a
gulp build
command which will run prettier, tsc, tslint.gulp
(default) now runs both build and test.Which issue(s) this PR fixes
Special notes for your reviewer: