fix (simpler) - cursor whenever changing editors - closes #2688 #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty straight forward to me! |
|
it was your idea after all ;) thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ModeHandler.syncCursors() and updateView() stopped being called on active editor changes after the bugfix to EditorIdentity because a window change wasn't being detected as a window change when the filename-only identity is identical :D.
getAndUpdateModeHandler() is called in a ton of places, so this PR adds a force-sync option, and has the ActiveEditorChange handler use it.
Which issue(s) this PR fixes
#2688
Special notes for your reviewer:
This PR restores the behavior to how it was before.
I took a wrong turn on another PR, but because of that, I noticed that there's some differences between selection change handling and editor switches. It's pretty clear from just the length of it ;), but for example, EOL-checking seems to behave slightly different when switching editors than when staying in the same editor. It's probably outside the scope of this issue, but I thought I'd mention it.