Fix issues with keybindings when changing to an editor in different mode #3108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix issues with keybindings when changing to an editor in different mode. This resulted in keybindings not working until changing modes again, including seeing
<Tab>
inserted as text in insert mode, if vscode thought we were in normal mode still.Which issue(s) this PR fixes
fixes #3096
fixes #730
fixes microsoft/vscode#59925
Special notes for your reviewer:
I'm not exactly sure why we don't have tests between editors. It would be nice to add tests here. I know that in the onDidChangeActiveTextEditor handler we even return automatically if
Globals.isTesting
is true.Anyway, there are two main changes here: