[Fixed] Reverse selection in normal mode #3124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2018 17:48
Given the reverse selection only selected the first character but forward selection worked fine, we change a reverse selection into a forward selection at the background so that everything works fine. Possible cause of the bug: getText() probably started from the right of the stop and then moved backward until it find's start but if it cannot do so, it just selects the first character as can be seen in the case of backward selection.
ghost
changed the title
ghost
changed the title
jpoon
reviewed
Nov 1, 2018
| @@ -1010,8 +1010,10 @@ class CommandOverrideCopy extends BaseCommand { | |||
| .map(range => { | |||
| const start = Position.EarlierOf(range.start, range.stop); | |||
| const stop = Position.LaterOf(range.start, range.stop); | |||
| return vimState.editor.document.getText(new vscode.Range(start, stop.getRight())); | |||
| }) | |||
| return start < stop | |||
There was a problem hiding this comment.
The docs for EarlierOf state:
/**
* Returns which of the 2 provided Positions comes earlier in the document.
*/
so start should always be >= stop.
What's the case when start < stop?
jpoon
requested changes
Nov 1, 2018
ghost
closed this
|
I think i read it wrong, and thought |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This takes care of problems faced during reverse selection where only the first letter of the codeblock used to be selected and the rest was ignored.
Which issue(s) this PR fixes #1951
Special notes for your reviewer: This seemed to be an issue with way getText() works on normal mode where it starts from the back and tries to move up finding where the start is and if it cannot find the start it returns only the first character as we began from the Right of stop.
The fix implemented just emulates a forward select when backward selection is made by the user and effectively works like a forward select.