Fix #2984: wrong tab selected after :quit

[insidewhy]

What this PR does / why we need it:

Fixes #2984, the wrong tab is being selected after :q which is very annoying.

Which issue(s) this PR fixes

#2984

Special notes for your reviewer:

The previous code (that this PR deleted) seems to be there to work around a bug in VS Code, since the VS Code issue has been fixed the code now leads to this bug.

[insidewhy]

I did a git lg -p on this file to find out why the code was introduced, unfortunately the commit message is a little cryptic: "71fc1d5b - make tab sequence feel right".

It seems VS Code behavior has changed since this commit and now leads to the sequence feeling right without needing any other behavior.

[insidewhy]

I debugged the code some more and I see that this.activeTextEditor.viewColumn never changes after running workbench.action.closeActiveEditor, no matter what tab I :q from. So the "select previous editor" logic that I'm deleting runs every single time, always leading you to the tab to the left of where you want to be.

[insidewhy]

I was concerned the problem might be caused by the interaction between VS Code Vim and another plugin, but after disabling all other plugins the issue still manifests.

[insidewhy]

@rebornix You wrote the original code for this, could you let me know what the intention was here? After reading into ViewColumn it looks to me like it wasn't the right approach, but then I'm confused as to why the issue with selecting the wrong tab only started happening 3 months ago and not earlier.

[insidewhy]

@rebornix Is there any way I can help with this or you could help me get this merged? It's a pretty serious and visible bug to have been around for so long.

[gohar94]

Any updates on this? It is EXTREMELY annoying to hit this countless times a day! :(

[rebornix]

@ohjames sorry for late reply, the code change looks good to me.

[insidewhy]

Thanks!

[gohar94]

Thanks, guys!