fix: disable nvim shada #3288
Merged
fix: disable nvim shada #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpoon Nvim 0.3.2 made a significant improvement to the behavior of https://github.com/neovim/neovim/wiki/Following-HEAD#20180922 Note that The NVim version is returned in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As recommended #3013 (comment), disable shada. @justinmk's second point has already been addressed: https://github.com/VSCodeVim/Vim/blob/master/src/neovim/neovim.ts#L32
Which issue(s) this PR fixes
#3013
Special notes for your reviewer: