Digraph support #3407
Merged
Digraph support #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @jbaiter, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fiTravisBuddy Request Identifier: 8150f4a0-1f4d-11e9-aff3-67b9a3119b8a |
jpoon
reviewed
Jan 31, 2019
| @@ -491,7 +540,7 @@ class CommandNavigateAutocompleteDown extends BaseCommand { | |||
| @RegisterAction | |||
| class CommandNavigateAutocompleteUp extends BaseCommand { | |||
| modes = [ModeName.Insert]; | |||
| keys = [['<C-p>'], ['<C-k>']]; | |||
| keys = ['<C-p>']; | |||
There was a problem hiding this comment.
This would be a breaking change. Not certain if this is ok...
There was a problem hiding this comment.
I couldn't get it to work otherwise, since the <C-k> shortcut will always prevent the <C-k> <any> <any> shortcut from firing.
I'm not even sure if <C-k> is actually referenced anywhere in the original vim for navigating up in the omnicomplete popup. All references to <C-k> in the neovim source code refer to digraphs. And the <C-k> for digraphs is definitely in the muscle memory of a lot of vim users.
There was a problem hiding this comment.
I'm trying to figure out what the appropriate keybinding would be for CommandNavigateAutocompleteUp and CommandNavigateAutocompleteDown.
These were initially added as a part of #1980. Likewise, I don't see <c-j> documented as autocompletedown in vim docs.
There was a problem hiding this comment.
It's defined here:
https://github.com/vim/vim/blob/d09091d4955c5f41de69928f2db85611ed54ed23/runtime/doc/index.txt#L157-L159
<C-n> for down, <C-p> for up.
Travis tests have failedHey @jbaiter, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; finpm test --silentTravisBuddy Request Identifier: 73c69b80-25a8-11e9-8e3a-a568437420b3 |
jbaiter
commented
Jan 31, 2019
Travis tests have failedHey @jbaiter, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; finpm test --silentTravisBuddy Request Identifier: 30f79ff0-25af-11e9-8e3a-a568437420b3 |
Travis tests have failedHey @jbaiter, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; finpm run buildnpm test --silentTravisBuddy Request Identifier: d0c3c440-2ec0-11e9-9ea4-33062c9ac3a7 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements support for digraphs.
All of the digraphs available in the current neovim version can be entered with
<C-k> <any> <any>.Additionally, users can configure custom digraphs with the
vim.customDigraphsconfiguration key. It maps two-character shorthands to a pair of a descriptive string and one or more UTF16 code points:{ "vim.customDigraphs": { "o:": ["ö", 62976], "R!": ["🚀", [55357, 56960]] } }A filterable list of all available digraphs can be obtained with the ex command
:dig[raphs], same as in Vim.Which issue(s) this PR fixes: #3267
Special notes for your reviewer: Unfortunately I had to remove the
<C-k>shortcut forCommandNavigateAutocompleteUp, since it prevented the<C-k> <any> <any>shortcut from being called.