-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate configurations once, instead of every key press #3418
Conversation
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: f18e0a50-23a3-11e9-b0c4-a3eb907e7b53 |
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 5e871950-23ac-11e9-b0c4-a3eb907e7b53 |
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: d07a2f10-23b2-11e9-b0c4-a3eb907e7b53 |
I ended up deleting this unit test that rebinded leader,f,e,s. I’m not sure how that rebounding worked initially as f, is an movement. |
but it there was a remap for |
Added the test back. I thought due to #1821, we couldn't have such keybindings, but was wrong (at least for normal mode) |
What this PR does / why we need it:
configuration
andlogger
. logger depended on configuration to configure its levels, configuration required logger to log config errors.Which issue(s) this PR fixes
Special notes for your reviewer: