fix: single-key remappings were being ignored #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
force-pushed
the
fix_3221
branch
3 times, most recently
from
7a77580
to
b1199fb
Compare
jpoon
force-pushed
the
fix_3221
branch
3 times, most recently
from
1ea076e
to
6138f02
Compare
This was referenced Jan 31, 2019
jpoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As we don't clear
this.vimState.recordedState.commandListin insert-mode, the remappers would never be called for single-key presses.This PR updates the logic when calling the remappers and adds a UT for the repro case stated in #3126.
I really hope I don't break other remappings.
Which issue(s) this PR fixes
#3126, #2965
Special notes for your reviewer: