-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yank highlighting (REBASED) #3593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Travis tests have failedHey @epeli, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 38b14240-47e3-11e9-9fd1-010f86d17016 |
Partially fixes VSCodeVim#2991 Fixes VSCodeVim#2333 Fixes VSCodeVim#2916 Supersedes VSCodeVim#3129 Co-authored-by: Esa-Matti Suuronen <esa-matti@suuronen.org>
esamattis
force-pushed
the
yank-highlight-rebase
branch
from
March 16, 2019 13:07
bd90887
to
0bf6ebd
Compare
Oops, there was a bug in my code after all. All green now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The original PR #3129 has been accepted for merge but there are few non trivial merge conflicts and the PR has been inactive for a while. This PR rebases @darfink's commits into an one commit and resolves the merge conflicts.
I've kept @darfink as the commit author but I've added myself as the co-author as this was not a trivial conflict resolution. Did some minor refactoring too.
Which issue(s) this PR fixes
Partially fixes #2991
Fixes #2333
Fixes #2916
Supersedes #3129
Special notes for your reviewer:
Some of the test were failing locally on the
VSCodeVim/Vim
master so they are failing in this branch too...