Support word motions for non-ASCII characters #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for your PR. Can you add tests? |
…into nonascii-word-motions
|
Thanks for taking the time to review this PR! I added a new test suite in |
jpoon
approved these changes
Apr 2, 2019
| @@ -108,7 +108,7 @@ export class Position extends vscode.Position { | |||
| constructor(line: number, character: number) { | |||
| super(line, character); | |||
|
|
|||
| this._nonWordCharRegex = this.makeWordRegex(Position.NonWordCharacters); | |||
| this._nonWordCharRegex = this.makeUnicodeWordRegex(Position.NonWordCharacters); | |||
There was a problem hiding this comment.
We don't need to address this on this particular PR, but we should move this initialization elsewhere such that is it statically constructed rather than having to create it over and over again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides a better support for word motions (w, b, ...) on non-ASCII characters (#3612).
The updated word motions act similarly to those in the original Vim, which distinguishes the different kinds of symbols such as ideographs, punctuations, and hiraganas, so that sequences of such symbols are treated as separate words. Therefore, cursors on Chinese or Japanese sentences do not jump too far away any more.
Which issue(s) this PR fixes
fixes #3612, fixes #3439.
Special notes for your reviewer: