Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence #362

Merged
merged 5 commits into from
Jun 27, 2016
Merged

Sentence #362

merged 5 commits into from
Jun 27, 2016

Conversation

rebornix
Copy link
Member

Sentence related movements.

A paragraph boundary is also a sentence boundary, so the regex can handle all sentence endings pattern. Another tricky part is when the cursor is at the end of a paragraph (seems it's also the beginning of next paragraph), next section will jump to the first non-whitespace character whether it's a valid sentence or not.

@rebornix
Copy link
Member Author

Add sentence backward and fix numeric prefix bugs.

@johnfn
Copy link
Member

johnfn commented Jun 27, 2016

Awesome!

The only thing I don't really like is the type of tests. In the future, I'd prefer using the newTest style and sending keys, because it's much easier to verify the test is correct just by looking at it (vs counting characters) and you're testing the thing you actually care about (vim motions) rather than internals of our code.

@johnfn johnfn merged commit 4705115 into VSCodeVim:master Jun 27, 2016
@rebornix
Copy link
Member Author

@johnfn agree, while writing cases I found newTest is the easiest way of validating line counts, cursor position, etc. I'll go with that in following commits.

@rebornix rebornix deleted the NextSentence branch June 27, 2016 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants