Fix word separation #3667
Merged
Fix word separation #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to the issue report #3680, it was found that Latin-1 symbols and punctuations were wrongly classified as word characters. I overlooked that the original Vim treats characters whose code point is less than This PR fixes #3680. |
jpoon
approved these changes
Apr 16, 2019
src/common/motion/position.ts
Outdated
| // Spelling alphabets are not listed here since they are covered as non-white letters. | ||
| // TODO(ajalab): add Emoji | ||
| const codePointRanges: [[number, number], CharKind][] = [ | ||
| const table: [[number, number], CharKind][] = [ |
There was a problem hiding this comment.
nit: rename this a more descriptive name.
There was a problem hiding this comment.
how about symbolTable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the degradation issue that words which contain diacritics (e.g.,
Städte) are separated in word motions.Which issue(s) this PR fixes
Two issues are reported in #3665:
vim.iskeywordcharacters (e.g.,helloWorld(param1) is wrongly regarded as a single word Word seperate doesn't works well #3665 (comment).adbdémm,Städte) is wrongly regarded as separate words Word seperate doesn't works well #3665 (comment).This PR fixes the second one. I've not been able to reproduce the original first problem...
Special notes for your reviewer:
makeAsciiWordSegmentsandmakeUnicodeWordSegments) are removed.